config2setopts: fix for --disable-aws configuration#20368
Closed
majstar wants to merge 1 commit intocurl:masterfrom
Closed
config2setopts: fix for --disable-aws configuration#20368majstar wants to merge 1 commit intocurl:masterfrom
majstar wants to merge 1 commit intocurl:masterfrom
Conversation
bagder
approved these changes
Jan 20, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I noticed that curl binary does not work as intended when built with --disable-aws setting. While using curl for http queries, it kept exiting with the following error:
The cause of the problem is the usage of
MY_SETOPT_STRmacro for settingCURLOPT_AWS_SIGV4inhttp_setopts()when other AWS-related code is disabled. Adding the corresponding#ifndefmacro fixed the problem.Also
resultvariable inhttp_setopts()should be preset toCURLE_OKvalue, because otherwisehttp_setopts()may return the value of uninitialised variable and the following error will occur:My commit fixes the problem.