Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the c-ares async resolver flow to treat Curl_dnscache_mk_entry() failure as an out-of-memory condition instead of continuing and potentially mapping it to a resolve error.
Changes:
- Detect
Curl_dnscache_mk_entry()returningNULLand returnCURLE_OUT_OF_MEMORY. - Simplify subsequent logic assuming the DNS entry exists once created (e.g., unconditional HTTPSRR block + cache add guarded only by
result).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #20385 at e27f2a5e: Test 3024 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.