send: drop CURL_UNCONST() from buffer argument on most platforms

[vszakats]

Keep it on platforms requiring a non-const buffer. These are AmigaOS and
OS400.

Also:

• replace SEND_QUAL_ARG2 with boolean macro SEND_NONCONST_ARG2.

[vszakats]

augment review

[vszakats]

@aisle-analyzer

[Copilot]

Pull request overview

This pull request modernizes the handling of the send() function's buffer argument const qualifier by replacing a macro-based const qualifier approach with a simpler boolean flag approach. Previously, SEND_QUAL_ARG2 was used to strip const from the buffer argument on most platforms by default. The new approach uses SEND_NONCONST_ARG2 to explicitly mark the two platforms (AmigaOS and OS400) that require non-const buffers, while all other platforms now properly use const buffers.

Changes:

• Replaced SEND_QUAL_ARG2 macro with boolean SEND_NONCONST_ARG2 macro
• Updated swrite macro to conditionally apply const based on platform requirements
• Removed legacy const-stripping logic from all config files except AmigaOS and OS400

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
projects/vms/config_h.com	Removes SEND_QUAL_ARG2 handling from VMS configuration script
lib/functypes.h	Defines SEND_NONCONST_ARG2 for AmigaOS and updates comment to reflect non-const signature
lib/curl_setup_once.h	Implements conditional const handling in swrite macro and updates documentation
lib/config-win32.h	Removes SEND_QUAL_ARG2 definition (Windows uses const by default)
lib/config-riscos.h	Removes SEND_QUAL_ARG2 definition (RISC OS uses const by default)
lib/config-os400.h	Replaces SEND_QUAL_ARG2 with SEND_NONCONST_ARG2 and updates comment
lib/config-mac.h	Removes SEND_QUAL_ARG2 definition (Mac uses const by default)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[augmentcode]

🤖 Augment PR Summary

Summary: This PR updates libcurl’s send() wrapper to preserve const on the buffer argument on most platforms.

Changes:

• Remove `SEND_QUAL_ARG2` from several platform config headers and from `functypes.h`.
• Introduce `SEND_NONCONST_ARG2` as a boolean macro to indicate platforms where `send()` requires a non-const buffer (AmigaOS, OS/400).
• Adjust `swrite()` in curl_setup_once.h to only apply CURL_UNCONST() when `SEND_NONCONST_ARG2` is defined; otherwise pass a const-qualified pointer.
• Update OS/400 and Amiga-specific definitions to set `SEND_NONCONST_ARG2`.
• Remove VMS config generation handling for `SEND_QUAL_ARG2` since the qualifier macro is no longer used.

Technical Notes: Default behavior is now “ARG2 accepts const”; only platforms that truly need it must opt in via SEND_NONCONST_ARG2.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.