Closed
Conversation
This requirement was already present for building tests and one of the examples.
4 tasks
bagder
approved these changes
Feb 3, 2026
dfandrich
approved these changes
Feb 3, 2026
docs/INTERNALS.md
Outdated
| not a requirement. The compiler must support a 64-bit integer type as well as | ||
| supply a stdint.h header file that defines C99-style fixed-width integer types | ||
| like uint32_t. | ||
| like uint32_t. The compiler must also support POSIX `strdup()`. |
Contributor
There was a problem hiding this comment.
Since line 16 already mentions that POSIX is assumed, I don't think this addition is necessary.
Member
Author
There was a problem hiding this comment.
I'm good with keeping it as short and simple. Pushed a commit to keep it as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop detecting this function and drop the local fallback.
Let us know if this update is causing an issue.
Notes:
_strdup()is required instead.strdup()/_strdup()were required before this patch to build one ofthe examples:
block_ip.strdup()/_strdup()were required in 8.18.0 and earlier to buildtests.