Skip to content

imap: add a check for Curl_meta_get()#20510

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/imap-meta-get
Closed

imap: add a check for Curl_meta_get()#20510
bagder wants to merge 1 commit intomasterfrom
bagder/imap-meta-get

Conversation

@bagder
Copy link
Member

@bagder bagder commented Feb 3, 2026

It should not return NULL, but if it does we need to bail out. Like we do elsewhere.a

Found by CodeSonar.

It should not return NULL, but if it does we need to bail out. Like we
do elsewhere.a

Found by CodeSonar.
@bagder bagder added the IMAP label Feb 3, 2026
@bagder
Copy link
Member Author

bagder commented Feb 3, 2026

augment review

@bagder
Copy link
Member Author

bagder commented Feb 3, 2026

@aisle-analyzer review

@aisle-research-bot
Copy link

aisle-research-bot bot commented Feb 3, 2026

🔒 Aisle Security Analysis

✅ We scanned this PR and did not find any security vulnerabilities.
Aisle supplements but does not replace security review.


Analyzed PR: #20510 at commit 81ac0c2

@augmentcode
Copy link

augmentcode bot commented Feb 3, 2026

🤖 Augment PR Summary

Summary: Adds a defensive NULL-check after fetching the per-easy IMAP metadata in the LIST/SEARCH response handler.

Why: Ensures the state machine bails out safely if Curl_meta_get() unexpectedly returns NULL (as flagged by CodeSonar), avoiding a potential NULL dereference.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@bagder bagder marked this pull request as ready for review February 3, 2026 16:20
@bagder bagder closed this in fdca2e0 Feb 3, 2026
@bagder bagder deleted the bagder/imap-meta-get branch February 3, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant