curl_setup.h: merge back single-use internal header curl_setup_once.h#20555
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
curl_setup.h: merge back single-use internal header curl_setup_once.h#20555vszakats wants to merge 1 commit intocurl:masterfrom
curl_setup_once.h#20555vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Originally split in 2006, but the issues cited are no longer present in current code. As of now both `curl_setup.h` and `curl_setup_once.h` are included once per compiler invocation, without recursion. The latter is just a sub-header of the former with no clear distinction in their contents. Merge them to avoid having to decide where to put new global PP logic. Also to make it easier to overview what gets defined globally and in what order. (Perhaps even giving way of some tidying up here.) Follow-up to 77b3bc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally split in 2006, but the issues cited are no longer present in
current code. As of now both
curl_setup.handcurl_setup_once.hareincluded once per compiler invocation, without recursion. The latter is
a sub-header of the former with no clear distinction in their contents.
Merge them to avoid having to decide where to put new global PP logic.
Also to make it easier to overview what gets defined/included globally
and in what order. (Perhaps even allowing some tidying up here.)
Follow-up to 77b3bc2