build: check MSG_NOSIGNAL directly, drop detection and interim macro#20559
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
build: check MSG_NOSIGNAL directly, drop detection and interim macro#20559vszakats wants to merge 1 commit intocurl:masterfrom
MSG_NOSIGNAL directly, drop detection and interim macro#20559vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Drop detecting it at configure time, along with the interim macro `HAVE_MSG_NOSIGNAL`. With current code, there is no longer a reason for this costly workaround. Also say in a comment that `sys/socket.h` is defining this macro. Follow-up to 77b3bc2
vszakats
changed the title
MSG_NOSIGNAL macro directlyMSG_NOSIGNAL directly, drop detection and interim macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop detecting it at configure time, along with the interim macro
HAVE_MSG_NOSIGNAL. There is no longer a reason for this workaround,and allows to save the work at configure time and simplify.
Also say in a comment that
sys/socket.his defining this macro.Follow-up to 77b3bc2