build: fix -Wunused-macros warnings, and related tidy-ups#20593
Closed
vszakats wants to merge 39 commits intocurl:masterfrom
Closed
build: fix -Wunused-macros warnings, and related tidy-ups#20593vszakats wants to merge 39 commits intocurl:masterfrom
-Wunused-macros warnings, and related tidy-ups#20593vszakats wants to merge 39 commits intocurl:masterfrom
Conversation
45a31c9 to
b9c5b49
Compare
-Wunused-macros warnings-Wunused-macros warnings, and related tidy-ups
44e2513 to
7b2a35a
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 15, 2026
Document functions/features needing it. Cherry-picked from curl#20593
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 15, 2026
Also to avoid `-Wunused-macros` warnings. Cherry-picked from curl#20593
vszakats
added a commit
that referenced
this pull request
Feb 15, 2026
vszakats
added a commit
that referenced
this pull request
Feb 15, 2026
fa655a6 to
3ab1c68
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 18, 2026
Cherry-picked from curl#20593
…misued in unity builds
CMakeLists.txt limit OPENSSL_SUPPRESS_DEPRECATED to OpenSSL in feature detections CMakeLists.txt cleanup openssl3 flow CMakeLists.txt cleanup openssl3 flow comment CMakeLists.txt update ossl3 deprec comment curl-openssl.m4 omit OPENSSL_SUPPRESS_DEPRECATED from version detection CMakeLists.txt update ossl3 depr funcs cm try limiting deprec suppression to lib tweak comment CMakeLists.txt update comment ossl3 curl_setup.h cleanup
…nSSL 3 only" TRY This reverts commit a45d81a.
This reverts commit 77cbf1fc9d9a0e702190b84739f0897d4c7c0029. Simpler/safer the other way. Potential downside is 3rd-party build systems. Also OPENSSL_SUPPRESS_DEPRECATED and the LIBRESSL macro remains in curl_setup.h, adding inconsistency.
This reverts commit 74e4792eaf4d76aafe76001f63b6304c101e0a29.
This reverts commit dd6028a.
3ab1c68 to
f250da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AN_APPLE_OSreused between sources withoutresetting it. It may potentially have left the system sha256
function unused.
WOLFSSL_OPTIONS_IGNORE_SYSso that it always appliesto wolfSSL headers, also during feature detection.
-Wunused-macroswarnings.The warning detects macros defined but not used within the same C
source. It does not warn for macros defined in headers. It also works
with unity builds, but to a lesser extent.
OPENSSL_SUPPRESS_DEPRECATEDto build level, and limit settingit for OpenSSL 3 (non-fork). Maybe in a separate PR. (see reverted sub-commit in this PR)
OPENSSL_SUPPRESS_DEPRECATEDto lib and feature checks. [same as above]or perhaps enable it in scheduled, non-unity, CI jobs? → SEPERATE PR. I'm thinking maybe enable it as a non-error warning could be useful. If there is good chance to fix remaining fallouts, and avoid future ones via CI, the warning can be made an error.
MD5_*andEVP_PKEY_get1_RSA, RSA_flags, RSA_freewhen building with OpenSSL 3,to avoid the
OPENSSL_SUPPRESS_DEPRECATEDwarnings in the first place. The logic is already present and used for OpenSSL 3 no-deprecated builds. [RATHER NOT, it'd mean NTLM is no longer available with ossl3]This leaves the example [FIXED] and TLS-SRP as the remining reasons. (TLS-SRP is a barely supported, insecure security feature.) [in context of this PR only examples were an issue]