Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes RTMP (librtmp-backed) support across curl/libcurl by deleting the protocol handler, dropping build/config integration, and updating documentation and CI to reflect that RTMP is no longer supported.
Changes:
- Remove RTMP protocol implementation and scheme/port/version plumbing from libcurl.
- Remove librtmp detection/configuration from Autotools, CMake, VMS tooling, and CI matrices.
- Update user-facing docs/help text to stop advertising RTMP and to record the removal.
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tool_help.c | Simplifies protocol listing (no RTMP special-casing). |
| scripts/schemetable.c | Drops RTMP-related schemes from scheme-table generator. |
| scripts/ciconfig.pl | Removes librtmp from CI config options list. |
| scripts/cd2nroff | Removes RTMP/RTMPS from known protocol map for docs generation. |
| projects/vms/generate_config_vms_h_curl.com | Removes USE_LIBRTMP handling from VMS config generation. |
| lib/version.c | Removes RTMP version reporting and RTMP schemes from supported protocol list. |
| lib/urldata.h | Removes RTMP default port constants. |
| lib/url.c | Removes RTMP scheme integration and regenerates perfect-hash scheme table without RTMP. |
| lib/curl_rtmp.h | Deletes RTMP scheme declarations / version helper header. |
| lib/curl_rtmp.c | Deletes RTMP protocol handler implementation. |
| lib/curl_config-cmake.h.in | Removes USE_LIBRTMP CMake config define. |
| lib/Makefile.inc | Removes RTMP source/header from build lists. |
| docs/libcurl/symbols-in-versions | Marks RTMP protocol macros as removed (version attribution needs alignment). |
| docs/libcurl/opts/CURLOPT_REDIR_PROTOCOLS_STR.md | Removes RTMP* from protocol string list. |
| docs/libcurl/opts/CURLOPT_PROTOCOLS_STR.md | Removes RTMP* from protocol string list and adds history note (version attribution needs alignment). |
| docs/cmdline-opts/_PROTOCOLS.md | Removes RTMP(S) section from command-line protocol docs. |
| docs/cmdline-opts/_DESCRIPTION.md | Removes RTMP/RTMPS from supported protocol list. |
| docs/URL-SYNTAX.md | Removes RTMP schemes, ports, and RTMP URL syntax section. |
| docs/INSTALL.md | Removes --without-librtmp from documented configure options. |
| docs/INSTALL-CMAKE.md | Removes USE_LIBRTMP and related variables from CMake documentation. |
| docs/HISTORY.md | Adds an entry about RTMP removal (currently written as a future date). |
| docs/FAQ.md | Removes RTMP/RTMPS from protocol list. |
| docs/DEPRECATE.md | Adds RTMP to “Past removals” list (version attribution needs alignment). |
| configure.ac | Removes --with/--without-librtmp support and protocol summary output for RTMP. |
| README.md | Removes RTMP/RTMPS from supported protocol list. |
| Makefile.am | Removes CMake/FindLibrtmp.cmake from distributed files. |
| CMakeLists.txt | Removes USE_LIBRTMP option, find_package wiring, and feature listing. |
| CMake/curl-config.in.cmake | Removes librtmp dependency propagation from generated curl-config CMake package. |
| CMake/FindLibrtmp.cmake | Deletes the CMake find-module for librtmp. |
| .github/workflows/macos.yml | Removes librtmp/rtmpdump from CI jobs (one job has an invalid CMake flag token). |
| .github/workflows/linux.yml | Removes librtmp packages/config flags from Linux CI jobs. |
| .github/workflows/linux-old.yml | Removes librtmp packages/config flags from legacy Linux CI jobs. |
| .github/workflows/codeql.yml | Removes librtmp from CodeQL build dependencies/config. |
| .github/scripts/cmp-config.pl | Removes librtmp header define from config comparison script. |
| .github/labeler.yml | Removes RTMP label automation rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
augment review |
🤖 Augment PR SummarySummary: This PR removes RTMP protocol support from curl/libcurl. Changes:
Technical Notes: RTMP depended on the external librtmp/rtmpdump codebase; this change eliminates that dependency and the associated maintenance/testing surface. 🤖 Was this summary useful? React with 👍 or 👎 |
Reported-by: Augment code URL: #20673 (review)
Reported-by: Augment code URL: #20673 (review) Closes #20679
- librtmp has no test cases, makes no proper releases and has not had a single commit within the last year - librtmp parses the URL itself and requires non-compliant URLs for this - we have no RTMP tests - RTMP is barely used by curl users (2.2% self-identified in the 2025 survey) Closes #20673
9e29faf to
da46dbd
Compare
- librtmp has no test cases, makes no proper releases and has not had a single commit within the last year - librtmp parses the URL itself and requires non-compliant URLs for this - we have no RTMP tests - RTMP is barely used by curl users (2.2% self-identified in the 2025 survey) Closes #20673
🔒 Aisle Security Analysis✅ We scanned this PR and did not find any security vulnerabilities. Aisle supplements but does not replace security review. Analyzed PR: #20673 at commit Last updated on: 2026-03-03T11:09:42Z |
- librtmp has no test cases, makes no proper releases and has not had a single commit within the last year - librtmp parses the URL itself and requires non-compliant URLs for this - we have no RTMP tests - RTMP is barely used by curl users (2.2% self-identified in the 2025 survey) Closes #20673
- librtmp has no test cases, makes no proper releases and has not had a single commit within the last year - librtmp parses the URL itself and requires non-compliant URLs for this - we have no RTMP tests - RTMP was used by 2.2% of curl users (self-identified in the 2025 survey) Closes #20673
- librtmp has no test cases, makes no proper releases and has not had a single commit within the last year - librtmp parses the URL itself and requires non-compliant URLs for this - we have no RTMP tests - RTMP was used by 2.2% of curl users (self-identified in the 2025 survey) Closes #20673
- librtmp has no test cases, makes no proper releases and has not had a single commit within the last year - librtmp parses the URL itself and requires non-compliant URLs for this - we have no RTMP tests - RTMP was used by 2.2% of curl users (self-identified in the 2025 survey) Closes #20673
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
librtmp has no test cases, makes no proper releases and has not had a single commit within the last year
librtmp parses the URL itself and requires non-compliant URLs for this
we have no RTMP tests
RTMP is barely used by curl users (2.2% self-identified in the 2025 survey)