cmake: always build curlu and curltool test libs in unity mode#20677
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: always build curlu and curltool test libs in unity mode#20677vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
To speed up building tests by default. Follow-up to fff9905 curl#20670
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To speed up building/running tests by default (e.g. via
testdepsorteststargets.)It reduces build commands to 21 (from 239) for a test build.
In CI, it affects build test step times as below:
12s https://github.com/curl/curl/actions/runs/22279958343/job/64448913413 →
6s https://github.com/curl/curl/actions/runs/22282767915/job/64455970302
39s https://github.com/curl/curl/actions/runs/22279958343/job/64448913430 →
37s https://github.com/curl/curl/actions/runs/22282767915/job/64455970352
22s https://github.com/curl/curl/actions/runs/22279958335/job/64448913514 →
15s https://github.com/curl/curl/actions/runs/22282767899/job/64455969960
23s https://github.com/curl/curl/actions/runs/22279958334/job/64448917225 →
9s https://github.com/curl/curl/actions/runs/22282767922/job/64455975006
Follow-up to fff9905 #20670