openssl: fix compiler warning with OpenSSL master#20681
Closed
openssl: fix compiler warning with OpenSSL master#20681
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a build warning when compiling curl’s OpenSSL TLS backend against OpenSSL master, where X509_get_X509_PUBKEY() now returns a const pointer.
Changes:
- Adjusts the
xpubkeylocal variable’s type inossl_certchain()to match OpenSSL’s updatedconstreturn type (guarded byHAVE_OPENSSL3).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vtls/openssl.c:469:15: error: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] X509_get_X509_PUBKEY() now returns a const pointer - but only on OpenSSL 3, we must keep the non-const version for all forks. Closes #20681
bagder
force-pushed
the
bagder/openssl-const
branch
from
b331b80 to
d9f5b3c
Compare
|
Analysis of PR #20681 at d9f5b3c5: Test ../../tests/http/test_07_upload.py::TestUpload::test_07_32_issue_10591[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vtls/openssl.c:469:15: error: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
X509_get_X509_PUBKEY() now returns a const pointer.