Conversation
A blob must have a length or it will not be accepted. By enforcing the check here, TLS backend code can rely on the fact that the length is always non-zero from this point. Reported-by: aisle-research-bot URL: #20689 (review)
Member
Author
🔒 Aisle Security Analysis✅ We scanned this PR and did not find any security vulnerabilities. Aisle supplements but does not replace security review. Analyzed PR: #20705 at commit |
There was a problem hiding this comment.
Pull request overview
This PR adds validation to reject blobs with zero length in the Curl_setblobopt function. This prevents out-of-bounds memory access in TLS backend code (specifically mbedTLS) where code accesses blob->data[blob->len - 1] to check for null termination, which would cause undefined behavior if len is 0.
Changes:
- Add zero-length validation check in
Curl_setblobopt()to reject blobs withlenequal to 0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
May 16, 2026
Prior to this patch the test was always skipped due to failing precheck with `CURLE_BAD_FUNCTION_ARGUMENT`, because of the zero-length blob passed to setopt. Fix by passing a non-zero long dummy blob as in `mk-lib1521.pl`. Follow-up to 956e1ae curl#20705
vszakats
added a commit
that referenced
this pull request
May 16, 2026
Prior to this patch the test was always skipped due to failing precheck with `CURLE_BAD_FUNCTION_ARGUMENT`, because of the zero-length blob passed to setopt. Fix by passing a non-zero long dummy blob as done in `mk-lib1521.pl`. Fixing: ``` test 0678 SKIPPED: CURLOPT_CAINFO_BLOB is not supported ``` Follow-up to 956e1ae #20705 Closes #21641
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
A blob must have a length or it will not be accepted. By enforcing the check here, TLS backend code can rely on the fact that the length is always non-zero from this point. Reported-by: aisle-research-bot URL: curl#20689 (review) Closes curl#20705
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Prior to this patch the test was always skipped due to failing precheck with `CURLE_BAD_FUNCTION_ARGUMENT`, because of the zero-length blob passed to setopt. Fix by passing a non-zero long dummy blob as done in `mk-lib1521.pl`. Fixing: ``` test 0678 SKIPPED: CURLOPT_CAINFO_BLOB is not supported ``` Follow-up to 956e1ae curl#20705 Closes curl#21641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A blob must have a length or it will not be accepted. By enforcing the check here, TLS backend code can rely on the fact that the length is always non-zero from this point.
Reported-by: aisle-research-bot
URL: #20689 (review)