clang-tidy: enable scanning headers - #20720
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
vszakats
marked this pull request as draft
February 25, 2026 14:02
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
1 task
This was referenced Feb 25, 2026
vszakats
added a commit
that referenced
this pull request
Feb 25, 2026
Pass system directories with `-isystem` to avoid clang-tidy parsing 3rd-party and system headers with `HeaderFilterRegex: '.*' enabled. Also: - drop rule exception no longer necessary. - sync normal vs. system header path order with compiler invocation. - tidy up `set()` syntax. - clear a temporary variable. Bug: #20670 (comment) Follow-up to e088e10 #17705 Cherry-picked from: #20720 Closes #20724
vszakats
added a commit
that referenced
this pull request
Feb 26, 2026
To fix building tests/server with cmake and both wolfSSL and OpenSSL
enabled (MultiSSL).
tests/server do not have libcurl dependency header paths setup because
it does not use libcurl. The code however includes `curl_setup.h`, which
tried including `wolfssl/version.h` before this patch to verify if the
wolfSSL coexist feature is available. Without a header path, it failed:
```
In file included from bld/tests/server/servers.c:3:
In file included from tests/server/first.h:40:
lib/curl_setup.h:737:12: fatal error: 'wolfssl/version.h' file not found
737 | # include <wolfssl/version.h>
| ^~~~~~~~~~~~~~~~~~~
1 error generated.
```
Ref: https://github.com/curl/curl/actions/runs/22410066319/job/64880787424#step:46:76
Fix by moving the include and version check to `vtls/wolfssl.c`.
Also: add an early version check to cmake.
Follow-up to 16f073e #16973
Cherry-picked from #20720
Closes #20726
vszakats
marked this pull request as ready for review
February 26, 2026 03:48
vszakats
changed the title
HeaderFilterRegex: '.*'
vszakats
changed the title
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Reported when running `HeaderFilterRegex: '.*'` in CI. Also replace an underscored symbol with a regular one in macro definition. Cherry-picked from curl#20720 Closes curl#20721
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Prefer `sizeof()` over `strlen()`, static const variables over macros. Add a couple of `NOLINT`s to silence false positives. Also sync similar code patterns between libtests. Cherry-picked from curl#20720 Closes curl#20723
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Pass system directories with `-isystem` to avoid clang-tidy parsing 3rd-party and system headers with `HeaderFilterRegex: '.*' enabled. Also: - drop rule exception no longer necessary. - sync normal vs. system header path order with compiler invocation. - tidy up `set()` syntax. - clear a temporary variable. Bug: curl#20670 (comment) Follow-up to e088e10 curl#17705 Cherry-picked from: curl#20720 Closes curl#20724
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
To fix building tests/server with cmake and both wolfSSL and OpenSSL
enabled (MultiSSL).
tests/server do not have libcurl dependency header paths setup because
it does not use libcurl. The code however includes `curl_setup.h`, which
tried including `wolfssl/version.h` before this patch to verify if the
wolfSSL coexist feature is available. Without a header path, it failed:
```
In file included from bld/tests/server/servers.c:3:
In file included from tests/server/first.h:40:
lib/curl_setup.h:737:12: fatal error: 'wolfssl/version.h' file not found
737 | # include <wolfssl/version.h>
| ^~~~~~~~~~~~~~~~~~~
1 error generated.
```
Ref: https://github.com/curl/curl/actions/runs/22410066319/job/64880787424#step:46:76
Fix by moving the include and version check to `vtls/wolfssl.c`.
Also: add an early version check to cmake.
Follow-up to 16f073e curl#16973
Cherry-picked from curl#20720
Closes curl#20726
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
By setting `HeaderFilterRegex: '.*'`. Closes curl#20720
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By setting
HeaderFilterRegex: '.*'.