clang-tidy: avoid/silence bugprone-not-null-terminated-result - #20723
Closed
vszakats wants to merge 3 commits into
Closed
clang-tidy: avoid/silence bugprone-not-null-terminated-result#20723vszakats wants to merge 3 commits into
bugprone-not-null-terminated-result#20723vszakats wants to merge 3 commits into
Conversation
```
/home/runner/work/curl/curl/tests/server/mqttd.c:354:3: error: the result from calling 'memcpy' is not null-terminated [bugprone-not-null-terminated-result,-warnings-as-errors]
354 | memcpy(&packet[3 + encodedlen], topic, topiclen);
| ^~~~~~ ~~~~~~~~~~
| strcpy (char *)
/home/runner/work/curl/curl/tests/server/rtspd.c:320:19: error: the result from calling 'memcpy' is not null-terminated [bugprone-not-null-terminated-result,-warnings-as-errors]
320 | memcpy(rtp_scratch + 4 + i, RTP_DATA, RTP_DATA_SIZE);
| ^~~~~~ ~~~~~~~~~~~~~~~
| strcpy
```
https://github.com/curl/curl/actions/runs/22405414997/job/64863682328?pr=20720
vszakats
force-pushed
the
ctidymemcpy
branch
from
February 25, 2026 20:33
59b77a8 to
6a04e97
Compare
vszakats
changed the title
bugprone-not-null-terminated-resultbugprone-not-null-terminated-result
vszakats
marked this pull request as draft
February 25, 2026 20:40
1 task
vszakats
marked this pull request as ready for review
February 25, 2026 21:10
vszakats
added a commit
that referenced
this pull request
Feb 26, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Prefer `sizeof()` over `strlen()`, static const variables over macros. Add a couple of `NOLINT`s to silence false positives. Also sync similar code patterns between libtests. Cherry-picked from curl#20720 Closes curl#20723
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Also: - imap-append: silence false positive (seen on Linux only). Follow-up to b1f853a curl#20731 Follow-up to 725c560 curl#20723 Closes curl#20743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer
sizeof()overstrlen(), static const variables over macros.Add a couple of
NOLINTs to silence false positives.Also sync similar code patterns between libtests.
Cherry-picked from #20720