build: do not include wolfSSL header in curl_setup.h#20726
Closed
vszakats wants to merge 10 commits intocurl:masterfrom
Closed
build: do not include wolfSSL header in curl_setup.h#20726vszakats wants to merge 10 commits intocurl:masterfrom
curl_setup.h#20726vszakats wants to merge 10 commits intocurl:masterfrom
Conversation
curl_setup.hcurl_setup.h
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix building tests/server with cmake and both wolfSSL and OpenSSL
enabled (MultiSSL).
tests/server do not have libcurl dependency header paths setup because
it does not use libcurl. The code however includes
curl_setup.h, whichtried including
wolfssl/version.hbefore this patch to verify if thewolfSSL coexist feature is available. Without a header path, it failed:
Ref: https://github.com/curl/curl/actions/runs/22410066319/job/64880787424#step:46:76
Fix by moving the include and version check to
vtls/wolfssl.c.Also: add an early version check to cmake.
Follow-up to 16f073e #16973
Cherry-picked from #20720