unit3205: suppress two clang-tidy false positives#20731
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
unit3205: suppress two clang-tidy false positives#20731vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Silencing:
```
tests/unit/unit3205.c:565:32: error: the result from calling 'memcpy' is not null-terminated [bugprone-not-null-terminated-result]
565 | expect = (const char *)memcpy(alt, "DHE-", 4);
| ^~~~~~ ~~~
| strcpy
tests/unit/unit3205.c:569:32: error: the result from calling 'memcpy' is not null-terminated [bugprone-not-null-terminated-result]
569 | expect = (const char *)memcpy(alt + 4, "DHE-", 4) - 4;
| ^~~~~~ ~~~
| strcpy
```
Ref: https://github.com/curl/curl/actions/runs/22425366818/job/64932197466?pr=20725
Cherry-picked from curl#20725
vszakats
added a commit
that referenced
this pull request
Feb 26, 2026
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 5, 2026
In favor or a small code change the silences the clang-tidy warning. Follow-up to b1f853a curl#20731
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silencing:
Ref: https://github.com/curl/curl/actions/runs/22425366818/job/64932197466?pr=20725
Cherry-picked from #20725