Skip to content

docs: Some nitpicks#20748

Closed
ffflorian wants to merge 2 commits intocurl:masterfrom
ffflorian:refactor/nitpicks
Closed

docs: Some nitpicks#20748
ffflorian wants to merge 2 commits intocurl:masterfrom
ffflorian:refactor/nitpicks

Conversation

@ffflorian
Copy link
Copy Markdown
Contributor

@ffflorian ffflorian commented Feb 26, 2026

Hi,

I did the following:

  • replaced double spaces with single space where applicable
  • replaced "favourite" with "favorite"
  • added language identifiers to code blocks in markdown files
  • added extra line after code blocks and after headings in markdown files

These are just nitpicks but I figured they would make this project even more perfect ✨

Feel free to edit this PR or request changes.

Copy link
Copy Markdown
Member

@vszakats vszakats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worthy adding 'favour' to .github/scripts/badwords.txt?

@ffflorian
Copy link
Copy Markdown
Contributor Author

@vszakats good idea, I'll amend my commit.

- replaced double spaces with single space where applicable
- replaced "favourite" with "favorite"
- added language identifiers to code blocks in markdown files
- added extra line after code blocks and after headings in markdown files
@github-actions github-actions bot added the CI Continuous Integration label Feb 26, 2026
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
bagder pushed a commit that referenced this pull request Feb 27, 2026
- replaced double spaces with single space where applicable
- replaced "favourite" with "favorite"
- added language identifiers to code blocks in markdown files
- added extra line after code blocks and after headings in markdown
  files

Cloes #20748
@bagder
Copy link
Copy Markdown
Member

bagder commented Feb 27, 2026

Thanks!

@bagder
Copy link
Copy Markdown
Member

bagder commented Feb 27, 2026

Closed via 006f561 (typo in commit)

@bagder bagder closed this Feb 27, 2026
@ffflorian ffflorian deleted the refactor/nitpicks branch February 28, 2026 05:48
@ninelore
Copy link
Copy Markdown

ninelore commented Mar 13, 2026

isnt "favour" vs "favor" just british english vs american english? I think this could create inconsistencies because there are alot more words where british english has 'ou' where american english has just an 'o'

Edit: grepped some british examples

curl on  master via △ 
> rg flavour
CMake/FindGSS.cmake
36:#   - `CURL_GSS_FLAVOUR`:  Custom property. "GNU" or "MIT" if detected.
139:      set(_gss_flavour "MIT")  # assume a default, should not really matter
155:        set(_gss_flavour "MIT")
173:        set(_gss_flavour "GNU")
180:    if(_gss_flavour)
192:  if(NOT _gss_flavour)
199:    set(_gss_flavour "GNU")
202:    set(_gss_flavour "MIT")
207:  message(STATUS "Found GSS/${_gss_flavour} (via pkg-config): ${_gss_INCLUDE_DIRS} (found version \"${_gss_version}\")")
213:  if(_gss_flavour STREQUAL "MIT")
241:    _gss_flavour
268:      INTERFACE_CURL_GSS_FLAVOUR "${_gss_flavour}"

configure.ac
2776:versioned_symbols_flavour=
2795:        versioned_symbols_flavour="$enableval"
2797:        versioned_symbols_flavour="MULTISSL_"
2799:        versioned_symbols_flavour="OPENSSL_"
2801:        versioned_symbols_flavour="MBEDTLS_"
2803:        versioned_symbols_flavour="WOLFSSL_"
2805:        versioned_symbols_flavour="GNUTLS_"
2807:        versioned_symbols_flavour="RUSTLS_"
2809:        versioned_symbols_flavour=""
2821:AC_SUBST([CURL_LIBCURL_VERSIONED_SYMBOLS_PREFIX], ["$versioned_symbols_flavour"])

src/Makefile.inc
27:# some make flavours. If we ever want to change this in a portable manner then

CMakeLists.txt
361:# Lib flavour selected for curl tool
368:# Lib flavour selected for example and test programs.
1307:    get_target_property(_gss_flavour CURL::gss INTERFACE_CURL_GSS_FLAVOUR)
1308:    if(_gss_flavour STREQUAL "GNU")

include/curl/curl.h
819: * CURLAUTH_DIGEST_IE    - HTTP Digest authentication with IE flavour

lib/hostip4.c
67: * flavours have thread-safe versions of the plain gethostbyname() etc.

lib/CMakeLists.txt
269:    # FreeBSD comes with the a.out and ELF flavours but a.out was supported

lib/functypes.h
51:#elif defined(__AMIGA__) /* Any AmigaOS flavour */

curl on  master via △ 
> rg  colour

curl on  master via △ 
> rg behaviour
lib/bufq.h
103: * Default behaviour: chunk limit is "hard", meaning attempts to write

tests/http/test_02_download.py
712:            # with urls larger than 64k, behaviour differs

.github/ISSUE_TEMPLATE/bug_report.yml
26:    id: expected-behaviour

tests/data/test357
57:# 1053700 x 'x', large enough to invoke the 100-continue behaviour

curl on  master via △ 
> rg flavour
include/curl/curl.h
819: * CURLAUTH_DIGEST_IE    - HTTP Digest authentication with IE flavour

CMake/FindGSS.cmake
36:#   - `CURL_GSS_FLAVOUR`:  Custom property. "GNU" or "MIT" if detected.
139:      set(_gss_flavour "MIT")  # assume a default, should not really matter
155:        set(_gss_flavour "MIT")
173:        set(_gss_flavour "GNU")
180:    if(_gss_flavour)
192:  if(NOT _gss_flavour)
199:    set(_gss_flavour "GNU")
202:    set(_gss_flavour "MIT")
207:  message(STATUS "Found GSS/${_gss_flavour} (via pkg-config): ${_gss_INCLUDE_DIRS} (found version \"${_gss_version}\")")
213:  if(_gss_flavour STREQUAL "MIT")
241:    _gss_flavour
268:      INTERFACE_CURL_GSS_FLAVOUR "${_gss_flavour}"

configure.ac
2776:versioned_symbols_flavour=
2795:        versioned_symbols_flavour="$enableval"
2797:        versioned_symbols_flavour="MULTISSL_"
2799:        versioned_symbols_flavour="OPENSSL_"
2801:        versioned_symbols_flavour="MBEDTLS_"
2803:        versioned_symbols_flavour="WOLFSSL_"
2805:        versioned_symbols_flavour="GNUTLS_"
2807:        versioned_symbols_flavour="RUSTLS_"
2809:        versioned_symbols_flavour=""
2821:AC_SUBST([CURL_LIBCURL_VERSIONED_SYMBOLS_PREFIX], ["$versioned_symbols_flavour"])

lib/hostip4.c
67: * flavours have thread-safe versions of the plain gethostbyname() etc.

src/Makefile.inc
27:# some make flavours. If we ever want to change this in a portable manner then

CMakeLists.txt
361:# Lib flavour selected for curl tool
368:# Lib flavour selected for example and test programs.
1307:    get_target_property(_gss_flavour CURL::gss INTERFACE_CURL_GSS_FLAVOUR)
1308:    if(_gss_flavour STREQUAL "GNU")

lib/CMakeLists.txt
269:    # FreeBSD comes with the a.out and ELF flavours but a.out was supported

lib/functypes.h
51:#elif defined(__AMIGA__) /* Any AmigaOS flavour */

@ffflorian
Copy link
Copy Markdown
Contributor Author

@ninelore yes, I just aligned the use of favour vs. favor - there were already more uses of favor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Development

Successfully merging this pull request may close these issues.

4 participants