cmake: convert curl_add_clang_tidy_test_target() macro to function#20760
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: convert curl_add_clang_tidy_test_target() macro to function#20760vszakats wants to merge 1 commit intocurl:masterfrom
curl_add_clang_tidy_test_target() macro to function#20760vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
It was a macro, in the belief this is necessary to have `get_directory_property()` and `CMAKE_CURRENT_SOURCE_DIR` work on the correct directory, but it turns out they do work the same when used in a function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought a macro is necessary to have
get_directory_property()andCMAKE_CURRENT_SOURCE_DIRwork on the correct directory, but it turnsout they do work the same when used in a function.