mbedtls: Guard TLS 1.3 + session tickets usage inside ifdef#20789
Closed
DanielDiazOrion wants to merge 1 commit intocurl:masterfrom
Closed
mbedtls: Guard TLS 1.3 + session tickets usage inside ifdef#20789DanielDiazOrion wants to merge 1 commit intocurl:masterfrom
DanielDiazOrion wants to merge 1 commit intocurl:masterfrom
Conversation
If TLS 1.3 is not supported, the call to
`mbedtls_ssl_conf_tls13_enable_signal_new_session_tickets()`
will fail during compilation:
../../curl-8.18.0/lib/vtls/mbedtls.c: In function 'mbed_connect_step1':
../../curl-8.18.0/lib/vtls/mbedtls.c:809:3: error: implicit declaration of function 'mbedtls_ssl_conf_tls13_enable_signal_new_session_tickets' [-Werror=implicit-function-declaration]
mbedtls_ssl_conf_tls13_enable_signal_new_session_tickets(&backend->config,
^
../../curl-8.18.0/lib/vtls/mbedtls.c:809:3: warning: nested extern declaration of 'mbedtls_ssl_conf_tls13_enable_signal_new_session_tickets' [-Wnested-externs]
Protect this call inside the `#ifdef` block by making sure
that support for TLS 1.3 is defined.
Signed-off-by: Daniel Díaz <daniel.diaz@sonos.com>
vszakats
approved these changes
Mar 2, 2026
Member
|
Thank you @DanielDiazOrion, merged now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If TLS 1.3 is not supported, the call to
mbedtls_ssl_conf_tls13_enable_signal_new_session_tickets()will fail during compilation:Protect this call inside the
#ifdefblock by making sure that support for TLS 1.3 is defined.