openssl: OpenSSL master added const to more APIs#20797
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adapts the curl OpenSSL TLS backend (lib/vtls/openssl.c) to compile cleanly against OpenSSL master, which is adding const qualifiers to several APIs. The changes add const to local variable declarations and function parameters to match the updated signatures.
Changes:
const ASN1_OBJECT *objinX509V3_extto matchX509_EXTENSION_get_object's now-const return typeconst ASN1_STRING *cast forASN1_STRING_printargument inX509V3_extconst X509_NAME *aparameter inx509_name_onelineto match updatedX509_NAME_print_exrequirementsconst X509_NAME *nameandconst ASN1_STRING *tmpinossl_verifyhostto match updated return types ofX509_get_subject_nameandX509_NAME_ENTRY_get_data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with OpenSSL master commit 2b5bb6148ff0ea44d4aa977c