Skip to content

openssl: OpenSSL master added const to more APIs#20797

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/const-openssl
Closed

openssl: OpenSSL master added const to more APIs#20797
bagder wants to merge 1 commit intomasterfrom
bagder/const-openssl

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Mar 3, 2026

Tested with OpenSSL master commit 2b5bb6148ff0ea44d4aa977c

@bagder bagder added the TLS label Mar 3, 2026
@bagder bagder marked this pull request as ready for review March 3, 2026 16:16
@bagder bagder requested a review from Copilot March 3, 2026 16:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adapts the curl OpenSSL TLS backend (lib/vtls/openssl.c) to compile cleanly against OpenSSL master, which is adding const qualifiers to several APIs. The changes add const to local variable declarations and function parameters to match the updated signatures.

Changes:

  • const ASN1_OBJECT *obj in X509V3_ext to match X509_EXTENSION_get_object's now-const return type
  • const ASN1_STRING * cast for ASN1_STRING_print argument in X509V3_ext
  • const X509_NAME *a parameter in x509_name_oneline to match updated X509_NAME_print_ex requirements
  • const X509_NAME *name and const ASN1_STRING *tmp in ossl_verifyhost to match updated return types of X509_get_subject_name and X509_NAME_ENTRY_get_data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bagder bagder closed this in d9c2c64 Mar 3, 2026
@bagder bagder deleted the bagder/const-openssl branch March 3, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants