Repository navigation
Conversation
PEM_read_bio_PrivateKey() is called with the wrong BIO, so the private key is not loaded. Follow-up to 8494012 Pointed out by Codex Security
There was a problem hiding this comment.
Pull request overview
Fixes the in-memory user certificate example so OpenSSL reads the private key from the correct BIO, ensuring the key actually loads.
Changes:
- Pass
kbio(private-key BIO) toPEM_read_bio_PrivateKey()instead ofbio(certificate BIO).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
approved these changes
Mar 3, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
PEM_read_bio_PrivateKey() is called with the wrong BIO, so the private key is not loaded. Follow-up to 8494012 Pointed out by Codex Security Closes curl#20800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEM_read_bio_PrivateKey() is called with the wrong BIO, so the private key is not loaded.
Follow-up to 8494012
Pointed out by Codex Security