Repository navigation
Conversation
This is debug-only code Follow-up to 20900e4 Found by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows/MS-DOS filename sanitization helper to avoid leaking the allocated target buffer when debug-only environment-variable fault injection paths are triggered.
Changes:
- Free
targetbefore returning from theCURL_FN_SANITIZE_BADdebug-injection error path. - Free
targetbefore returning from theCURL_FN_SANITIZE_OOMdebug-injection error path. - Add braces around the debug-only
if(getenv(...))blocks to safely include cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
vszakats
approved these changes
Mar 3, 2026
bagder
marked this pull request as ready for review
March 6, 2026 21:47
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
This is debug-only code Follow-up to 20900e4 Found by Codex Security Closes curl#20804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is debug-only code
Follow-up to 20900e4
Found by Codex Security