content_encoding: return 'identity' if none other exists#20805
Closed
content_encoding: return 'identity' if none other exists#20805
Conversation
This fixes a regression and accidental changed behavior shipped in 8.18.0 (via 6b9c75e). When the setopt is set to "" and curl is built without support for a single compression algorithm, it used to use "identity" but recently did not. Spotted by Codex Security
|
Analysis of PR #20805 at 1671213d: Test ../../tests/http/test_07_upload.py::TestUpload::test_07_32_issue_10591[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression and accidental changed behavior shipped in 8.18.0 (via 6b9c75e).
When the setopt is set to "" and curl is built without support for a single compression algorithm, it used to use "identity" but recently did not.
Spotted by Codex Security