Skip to content

synctime: fix use of uninitialized buffer on non-Windows#20806

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/synctime
Closed

synctime: fix use of uninitialized buffer on non-Windows#20806
bagder wants to merge 1 commit intomasterfrom
bagder/synctime

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Mar 3, 2026

Follow-up to: b714c67

Spotted by Codex Security

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Mar 3, 2026

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 3, 2026

🤖 Augment PR Summary

Summary: Prevents an uninitialized read in the synctime example on non-Windows builds.

Changes: Initializes timeBuf to an empty string so the "Before HTTP" date log cannot print uninitialized stack data (follow-up to b714c67 / Codex Security report).

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@bagder bagder marked this pull request as ready for review March 4, 2026 10:10
@bagder bagder closed this in e49efce Mar 6, 2026
@bagder bagder deleted the bagder/synctime branch March 6, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants