Repository navigation
Conversation
If the first write was interrupted by a signal and a subsequent write succeeds, the function would still erroneously return EINTR. Found by Codex Security
There was a problem hiding this comment.
Pull request overview
Fixes Curl_wakeup_signal() so it does not incorrectly return EINTR after a successful retry when the initial wakeup_write() was interrupted by a signal. This impacts the wakeup mechanism used by curl_multi_wakeup() / async resolver notification paths.
Changes:
- Reset
errat the start of each retry loop iteration inCurl_wakeup_signal()so a successful retry returns0rather than a staleEINTR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
If the first write was interrupted by a signal and a subsequent write succeeds, the function would still erroneously return EINTR. Found by Codex Security Closes curl#20809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the first write was interrupted by a signal and a subsequent write succeeds, the function would still erroneously return EINTR.
Found by Codex Security