Fix spelling in a couple of locally used macros#20810
Closed
flavioamieiro wants to merge 1 commit intocurl:masterfrom
Closed
Fix spelling in a couple of locally used macros#20810flavioamieiro wants to merge 1 commit intocurl:masterfrom
flavioamieiro wants to merge 1 commit intocurl:masterfrom
Conversation
The `ISLOWHEXALHA` and `ISUPHEXALHA` macros were introduced in commit f65f750 and seem to be only referenced locally by the ISXDIGIT macro. Judging by the ISALPHA macro defined in the same file, it seems like the intention was to spell them as IS.*HEXALPHA.
vszakats
approved these changes
Mar 4, 2026
Contributor
Author
|
Quick ping here to see if there's anything I can do to improve this so it's merged (or if you deem it too small of a change to do so) as some time has passed after approval. |
Member
|
Thanks @flavioamieiro, nothing else to be done, it's merged now! |
Contributor
Author
|
Thank you @vszakats ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ISLOWHEXALHAandISUPHEXALHAmacros were introduced in commit f65f750 and seem to be only referenced locally by theISXDIGITmacro.Judging by the
ISALPHAmacro defined in the same file, it seems like the intention was to spell them asIS.*HEXALPHA.I noticed this while reading through the code and decided to open a PR, even if it is only a tiny change, just because I was already looking at it and it might be useful. If there is any reason not to merge this, please do close the PR.