Conversation
Perform the actual timeout calculation in the blocking resolv loop each time in the same way, keeping the logic simpler. The previous version calculated the timeout once, and then reduced it by the elapsed time spent in polling/processing. This is unnecessarily complicated.
bagder
approved these changes
Mar 6, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Perform the actual timeout calculation in the blocking resolv loop each time in the same way, keeping the logic simpler. The previous version calculated the timeout once, and then reduced it by the elapsed time spent in polling/processing. This is unnecessarily complicated. Closes curl#20819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform the actual timeout calculation in the blocking resolv loop each time in the same way, keeping the logic simpler.
The previous version calculated the timeout once, and then reduced it by the elapsed time spent in polling/processing. This is unnecessarily complicated.