quiche: use PRIu64 for outputting the stream id#20849
Closed
Conversation
The 'id' struct field in 'struct h3_stream_ctx' is a uint64_t type so should be output with PRIu64 - and it makes sense to be consistent. Note that the field with the same name in the ngtcp2 version of this struct is a *signed* 64-bit variable. Reported by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR fixes format specifier mismatches in lib/vquic/curl_quiche.c where stream->id (a uint64_t field) was being printed using PRId64 (signed) instead of PRIu64 (unsigned). The PR description correctly notes that the ngtcp2 version of this struct uses a signed int64_t for the same field name, making it important to use the appropriate specifier in each backend.
Changes:
- Changed four instances of
PRId64toPRIu64when formatting thestream->idfield in trace and error messages, matching the actualuint64_ttype of the field.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'id' struct field in 'struct h3_stream_ctx' is a uint64_t type so should be output with PRIu64 - and it makes sense to be consistent.
Note that the field with the same name in the ngtcp2 version of this struct is a signed 64-bit variable.
Reported by Codex Security