urlapi: verify the last letter of a scheme when set explictly

[bagder]

A logic error made the function not check the last character, which thus could make it accept invalid schemes.

Added test 1965 to verify

Reported-by: Otis Cui Lei

[Copilot]

Pull request overview

Fixes a URL API scheme-validation bug where the last character of an explicitly set (non-built-in) scheme was not validated, which could allow invalid schemes to be accepted. Adds a new libtest + testcase to cover a matrix of valid/invalid scheme strings and maximum-length behavior.

Changes:

• Fix set_url_scheme() validation to correctly check the final character of custom schemes.
• Add new libtest lib1965 that exercises curl_url_set(CURLUPART_SCHEME, ...) with various scheme strings.
• Register the new test in the libtest and tests/data build/test lists.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/urlapi.c	Fixes scheme-validation loop to include the last character.
tests/libtest/lib1965.c	New libtest that prints ACCEPTED/REJECTED for a list of schemes.
tests/libtest/Makefile.inc	Adds lib1965.c to the libtest build.
tests/data/test1965	New testcase verifying expected stdout from lib1965.
tests/data/Makefile.am	Registers test1965 in the testcases list.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.