build: compiler warning silencing tidy-ups#20908
Closed
vszakats wants to merge 16 commits intocurl:masterfrom
Closed
build: compiler warning silencing tidy-ups#20908vszakats wants to merge 16 commits intocurl:masterfrom
vszakats wants to merge 16 commits intocurl:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
vszakats
changed the title
vszakats
changed the title
Fallouts: - Windows / dl-mingw, CM 6.4.0-i686 schannel !unity (pull_request) D:/a/curl/curl/tests/unit/unit1652.c:112:3: error: reading through null pointer (argument 3) [-Werror=format=] Curl_infof(easy, "%s", (char *)NULL); ^~~~~~~~~~ https://github.com/curl/curl/actions/runs/23011479533/job/66822966645?pr=20908 - Windows / dl-mingw, CM 7.3.0-x86_64 schannel mbedtls U (pull_request) D:/a/curl/curl/tests/unit/unit1652.c:112:3: error: reading through null pointer (argument 3) [-Werror=format=] Curl_infof(easy, "%s", (char *)NULL); ^~~~~~~~~~ https://github.com/curl/curl/actions/runs/23011479533/job/66822966647?pr=20908 - old linux /__w/curl/curl/tests/unit/unit1652.c:112:3: error: reading through null pointer (argument 3) [-Werror=format=] Curl_infof(easy, "%s", (char *)NULL); ^~~~~~~~~~ https://github.com/curl/curl/actions/runs/23011479414/job/66822941242?pr=20908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tool_getparam: revert an unnecessary/no-op C89 warning silencer.
Follow-up to 09c9afd cmake: silence silly Apple clang warnings in C89 mode, test in CI #20363
tool_writeout: add comment saying silencing is a no-op for llvm/clang.
For
strftime()it is a GCC-specific, as of llvm/clang v22.1.0.Follow-up to f07a98a build: drop global suppression of
-Wformat-nonliteral, fix fallouts #20366unit1652: drop always-false
!defined(__clang__)guard.Pointed-out-by: Orgad Shaneh
Ref: Fix compilation with GCC 4.3 #20902
Follow-up to 7e814c8 build: fix compiling with GCC 4.x versions #16062
unit1652: document that
-Wformatis necessary for GCC v5 to v8.Follow-up to 71cf0d1 tests: speed up builds with single-binary test bundles #14772