Skip to content

improve port types and conn destination format#20918

Closed
icing wants to merge 2 commits intocurl:masterfrom
icing:ports-conn-destination
Closed

improve port types and conn destination format#20918
icing wants to merge 2 commits intocurl:masterfrom
icing:ports-conn-destination

Conversation

@icing
Copy link
Copy Markdown
Contributor

@icing icing commented Mar 13, 2026

Convert more int port to uint16_t port types.
Reshuffle ports in connectdata to save some bytes. Change conn->destination format to

  • make it more readable and thus usable in tracing
  • add the IPv6 scope_id only when not default (global) and make it resemble more the textual format for IPv6 (e.g. suffix '%<scope_id>')

@icing
import port types and conn destination format
6e63681 
Convert more `int port` to `uint16_t` port types.
Reshuffle ports in connectdata to save some bytes.
Change `conn->destination` format to

- make it more readable and thus usable in tracing
- add the IPv6 scope_id only when not default (global)
  and make it resemble more the textual format for IPv6
  (e.g. suffix '%<scope_id>')
@icing icing added the tidy-up label Mar 13, 2026
@icing icing changed the title import port types and conn destination format improve port types and conn destination format Mar 13, 2026
@testclutch
Copy link
Copy Markdown

testclutch commented Mar 13, 2026

Analysis of PR #20918 at fece8ebe:

Test 2053 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@bagder bagder closed this in 9325eb5 Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

tidy-up

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@icing @testclutch @bagder