connection bit ipv6_ip misleading, remove#20919
Closed
icing wants to merge 3 commits intocurl:masterfrom
Closed
Conversation
The connectdata bit `ipv6_ip` is set from the URL of the transfer *creating* the connection. When the connection is reused, the bit is not inherited from the "needle". A modified test2058 fails when running a curl built without proxy support.
The bit was only correct for the first transfer using a connection. Use `data->state.up.hostname` instead in places that need the URL hostname in its original form. Fix parseurlandfillconn() to not modify `data->state.up.hostname` before copying the connection's hostname, but modify the copy instead, leaving the URL hostname intact.
icing
changed the title
…ed connection hostname.
bagder
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate
conn->bits.ipv6_ipThe bit was only correct for the first transfer using a connection. Use
data->state.up.hostnameinstead in places that need the URL hostname in its original form.Fix parseurlandfillconn() to not modify
data->state.up.hostnamebefore copying the connection's hostname, but modify the copy instead, leaving the URL hostname intact.