ldap: drop duplicate ldap_set_option() on Windows

[vszakats]

Already set after ldap_sslinit()/ldap_init() and before
ldap_ssl-specific initialization.

Follow-up to 39d1976 #19830
Follow-up to b41e65a
Follow-up to b91421b

---

/cc @gknauf

[vszakats]

I found no sign that protocol version could be reset by other
set options, but also can't test this, without an LDAPS server.
If someone can, please do.

[vszakats]

augment review

[vszakats]

@aisle-analyzer

[augmentcode]

🤖 Augment PR Summary

Summary: Removes a redundant Windows-specific call to set the LDAP protocol version during bind setup.

Why: The protocol version is already configured earlier after ldap_sslinit()/ldap_init(), so the extra ldap_set_option(LDAP_OPT_PROTOCOL_VERSION, ...) before ldap_win_bind() was duplicate.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

[Copilot]

Pull request overview

This PR removes a redundant Windows-only ldap_set_option(LDAP_OPT_PROTOCOL_VERSION, ...) call in the LDAP transfer path, relying on the existing option setup that already happens immediately after ldap_sslinit()/ldap_init().

Changes:

• Drop duplicate ldap_set_option(... LDAP_OPT_PROTOCOL_VERSION ...) just before ldap_win_bind() on Windows builds.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[vszakats]

Thanks for verifying, @MarcelRaad!