curl-wolfssl.m4: fix to use the correct value for pkg-config directory#20943
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
curl-wolfssl.m4: fix to use the correct value for pkg-config directory#20943vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Before this patch the `$withval` variable may have contained `yes` (or other unrelated values) instead of the wolfSSL directory configured with `--with-wolfssl=`. Fixing: ``` checking for wolfssl options with pkg-config... found configure: pkg-config --exists wolfssl trace: ---- begin PKG_CONFIG_PATH: |/home/runner/wolfssl/build/lib/pkgconfig:/home/runner/nghttp3/build/lib/pkgconfig:/home/runner/ngtcp2/build/lib/pkgconfig:/home/runner/nghttp2/build/lib/pkgconfig| PKG_CONFIG_LIBDIR: |yes/lib/pkgconfig| <=============== 'yes' used as base directory trying path: /home/runner/wolfssl/build/lib/pkgconfig for wolfssl ---- end ``` Ref: https://github.com/curl/curl/actions/runs/23146424326/job/67235762794?pr=20920#step:18:245 Cherry-picked from curl#20920
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 16, 2026
Tidy up, for robustness and consistency. Ref: curl#20943 Cherry-picked from curl#20920
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch the
$withvalvariable may have containedyesorother unrelated values, instead of the wolfSSL directory configured via
--with-wolfssl=.Fixing:
Ref: https://github.com/curl/curl/actions/runs/23146424326/job/67235762794?pr=20920#step:18:245
Cherry-picked from #20920