Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Removes legacy SSLv2-specific message/version decoding paths from the OpenSSL TLS backend’s debug/trace helpers, aligning the code with modern OpenSSL/LibreSSL capabilities and reducing obsolete compatibility branches.
Changes:
- Dropped SSLv2 handshake message name mapping from
ssl_msg_type(). - Dropped SSLv2 version-string handling from
ossl_trace().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
Author
|
augment review |
🤖 Augment PR SummarySummary: Removes legacy SSLv2 message/version decoding from the OpenSSL trace helpers in curl’s OpenSSL backend. Why: SSLv2 is obsolete (and removed from modern OpenSSL/LibreSSL), so keeping the conditional SSLv2 code paths is unnecessary maintenance overhead. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
vszakats
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.