tool_urlglob: fix memory-leak on glob range overflow - #20956
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Follow-up to 5f273fd Pointed out by Codex Security
There was a problem hiding this comment.
Pull request overview
Fixes a memory leak in the URL globbing parser when a {...} set grows beyond the allowed size (“range overflow”), ensuring allocated set elements are freed on error.
Changes:
- Replace a direct early
returnon set-size overflow inglob_set()with setting an error code and jumping to the shared cleanup path (goto error).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bagder
marked this pull request as ready for review
March 17, 2026 12:41
Member
|
Reminds me of gcc analyzer finding a leak here in #20921: will be interesting to retest after merging, and perhaps unsilence if fixed. |
vszakats
pushed a commit
to vszakats/curl
that referenced
this pull request
Mar 17, 2026
Follow-up to 5f273fd Pointed out by Codex Security Closes curl#20956
Member
It's a different leak (if real.) |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Follow-up to 5f273fd Pointed out by Codex Security Closes curl#20956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 5f273fd
Pointed out by Codex Security