Skip to content

imap: reset the UIDVALIDITY state between transfers#20962

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/uidvailidity-reset
Closed

imap: reset the UIDVALIDITY state between transfers#20962
bagder wants to merge 1 commit intomasterfrom
bagder/uidvailidity-reset

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Mar 17, 2026

uidvalidity_set and mb_uidvalidity_set flags were never reset, leaving a risk for stale UIDVALIDITY state across transfers and mailbox switches.

Follow-up to fb6a480

Spotted by Codex Security

uidvalidity_set and mb_uidvalidity_set flags were never reset, leaving a
risk for stale UIDVALIDITY state across transfers and mailbox switches.

Follow-up to fb6a480

Spotted by Codex Security
@bagder bagder added the IMAP label Mar 17, 2026
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Mar 17, 2026

augment review

@bagder bagder marked this pull request as ready for review March 17, 2026 15:26
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 17, 2026

🤖 Augment PR Summary

Summary: Resets IMAP UIDVALIDITY tracking flags when changing mailboxes and between transfers to avoid stale UIDVALIDITY state leaking across requests.

Changes: Clears imapc->mb_uidvalidity_set on SELECT mailbox switches and clears imap->uidvalidity_set in imap_easy_reset, ensuring UIDVALIDITY parsing/checks are per-mailbox/per-transfer.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@bagder bagder closed this in a46816b Mar 17, 2026
@bagder bagder deleted the bagder/uidvailidity-reset branch April 3, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant