tool_formparse: pass on errors from my_get_line when reading headers#20963
Closed
tool_formparse: pass on errors from my_get_line when reading headers#20963
Conversation
The read_field_headers() function would return "ok" even if the underlying file read returned error, thus would the parent not become aware of the problem. Follow-up to f847d2e Found by Codex Security
There was a problem hiding this comment.
Pull request overview
Ensures the curl tool’s form header-file parsing propagates underlying my_get_line() read failures so callers can detect and abort instead of incorrectly treating the read as successful.
Changes:
- Detect
my_get_line()/get_line()signaled read failure via theerrorflag after the header-reading loop. - Emit an error message and return failure from
read_field_headers()when such a read error occurs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read_field_headers() function would return "ok" even if the underlying file read returned error, thus would the parent not become aware of the problem.
Follow-up to f847d2e
Found by Codex Security