Skip to content

asyn-ares: fix HTTPS-lookup when not on port 443 - #20966

Closed
bagder wants to merge 1 commit into
masterfrom
bagder/https-typo
Closed

asyn-ares: fix HTTPS-lookup when not on port 443#20966
bagder wants to merge 1 commit into
masterfrom
bagder/https-typo

Conversation

@bagder

@bagder bagder commented Mar 17, 2026

Copy link
Copy Markdown
Member

Follow-up to 8d0bfe7

Spotted by Codex Security

Follow-up to 8d0bfe7

Spotted by Codex Security
@bagder bagder added the name lookup DNS and related tech label Mar 17, 2026
@bagder

bagder commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

augment review

@bagder
bagder marked this pull request as ready for review March 17, 2026 22:55
@augmentcode

augmentcode Bot commented Mar 17, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Fixes how asyn-ares builds the HTTPS RR lookup name for targets using a non-443 port.
Why: Generates the correct _port._https.<hostname> form so HTTPS RR/SVCB resolution works for alternate ports.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@bagder bagder closed this in 02e04ea Mar 18, 2026
@bagder
bagder deleted the bagder/https-typo branch March 18, 2026 09:26
dkarpov1970 pushed a commit to dkarpov1970/curl that referenced this pull request Mar 25, 2026
Follow-up to 8d0bfe7

Spotted by Codex Security

Closes curl#20966
outcast36 pushed a commit to greearb/curl that referenced this pull request Jun 3, 2026
Follow-up to 8d0bfe7

Spotted by Codex Security

Closes curl#20966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

name lookup DNS and related tech

Development

Successfully merging this pull request may close these issues.

1 participant