Repository navigation
Conversation
As we run this script in CI, this should reduce the risk of mischief Found by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR hardens scripts/top-complexity by avoiding shell-invoked pipelines/backticks and instead using list-form open(..., "-|", ...) to run git ls-files and pmccabe more safely.
Changes:
- Replace
open(F, "git ls-files ... |")with list-formopen(my $git, "-|", "git", "ls-files", ...). - Replace backticks execution of
pmccabewith list-formopen(my $pmc, "-|", $pmccabe, @files). - Explicitly close the new pipe filehandles.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bagder
marked this pull request as ready for review
March 18, 2026 09:24
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
As we run this script in CI, this should reduce the risk of mischief Found by Codex Security Closes curl#20969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we run this script in CI, this should reduce the risk of mischief
Found by Codex Security