Fix errors detected by scan-build #2098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a scan-build warning.
jay
reviewed
Nov 20, 2017
| @@ -722,7 +722,6 @@ static size_t readback_bytes(mime_state *state, | |||
| sz = numbytes - state->offset; | |||
|
|
|||
| if(numbytes > state->offset) { | |||
| sz = numbytes - state->offset; | |||
There was a problem hiding this comment.
I don't see how this one is right. sz is used later on
There was a problem hiding this comment.
nm I see it now, it was set above. it would probably be easier to understand if it was set here and the one above removed
There was a problem hiding this comment.
Yeah probably, was more thinking that it could benefit of being set unconditionally first so that one wouldn't think it risked ending up not being set...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran scan-build on the code and cleaned up some low hanging fruit. The automated scan-build I run uses a much older clang version and didn't catch any of these!