tool_operate: fix condition for loading curl-ca-bundle.crt (Windows)#20989
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
tool_operate: fix condition for loading curl-ca-bundle.crt (Windows)#20989vszakats wants to merge 1 commit intocurl:masterfrom
curl-ca-bundle.crt (Windows)#20989vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
It was incorrecly loaded with env `CURL_CA_BUNDLE` unset + `SSL_CERT_DIR` set + `SSL_CERT_FILE` unset. Found by Codex Security Follow-up to 29bce98 curl#11325 curl#11531
Member
Author
|
augment review |
🤖 Augment PR SummarySummary: Fix Windows CA bundle auto-discovery so 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Fixes Windows-specific CA bundle auto-discovery logic in curl so curl-ca-bundle.crt is only searched/loaded when neither --capath/SSL_CERT_DIR nor --cacert/SSL_CERT_FILE/CURL_CA_BUNDLE has provided a CA location.
Changes:
- Update the Windows fallback condition to check
config->capath/config->cacertrather than the transientenvpointer state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was incorrecly loaded with env
CURL_CA_BUNDLEunset +SSL_CERT_DIRset +SSL_CERT_FILEunset.Found by Codex Security
Follow-up to 29bce98 #11325 #11531