openssl: fix memory leaks in ECH code (OpenSSL 3)#20993
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
openssl: fix memory leaks in ECH code (OpenSSL 3)#20993vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Also drop an unnecessary cast. Found by Codex Security Follow-up to a362962 curl#11922
vszakats
changed the title
Member
Author
|
augment review |
🤖 Augment PR SummarySummary: Fixes OpenSSL 3 ECH retry-config tracing cleanup by freeing the 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Fixes OpenSSL ECH-related memory leaks in the vtls OpenSSL backend by ensuring all heap-allocated values returned from ECH query helpers are freed.
Changes:
- Free
inner/outerstrings returned bySSL_ech_get1_status()in the retry-config tracing path. - Drop an unnecessary cast when freeing
rcs(retry-config buffer) withOPENSSL_free().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Mar 25, 2026
Also drop an unnecessary cast. Found by Codex Security Follow-up to a362962 curl#11922 Closes curl#20993
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also drop an unnecessary cast.
Found by Codex Security
Follow-up to a362962 #11922