INSTALL.md: update Cygwin instructions#20995
Closed
jhauga wants to merge 15 commits intocurl:masterfrom
Closed
Conversation
Add --disable-shared flag to Cygwin build instructions to avoid libtool errors during the shared library linking phase. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> INSTALL.md: update cygwin instructions
vszakats
reviewed
Mar 19, 2026
jhauga
commented
Mar 19, 2026
Suggest error resolutions.
jhauga
commented
Mar 19, 2026
jhauga
commented
Mar 19, 2026
Resolve `codespell`, and update the context of the last sentence.
jhauga
commented
Mar 19, 2026
Resolve `spacecheck`
|
Analysis of PR #20995 at 920ee9e9: Test 1275 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 336 different CI jobs (the link just goes to one of them). Generated by Testclutch |
vszakats
requested changes
Mar 19, 2026
jhauga
commented
Mar 25, 2026
vszakats
reviewed
Mar 25, 2026
jhauga
commented
Mar 26, 2026
jhauga
commented
Mar 30, 2026
jhauga
commented
Mar 30, 2026
vszakats
reviewed
Mar 30, 2026
jhauga
commented
Mar 30, 2026
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com> Co-authored-by: John Haugabook <johnhaugabook@gmail.com>
vszakats
approved these changes
Mar 30, 2026
Member
|
@jhauga Maybe update/resync PR description with the actual changes made? |
vszakats
changed the title
Member
|
Thanks! Merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish Cygwin section of install, adding suggestions for:
cmakeninjasetup --build-depends