Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes proxy parsing in lib/url.c so that SOCKS proxy URLs are parsed using the SOCKS proxy type (rather than reusing the HTTP proxy type), ensuring the parsed proxy information is stored in the correct conn->socks_proxy fields.
Changes:
- Pass
conn->http_proxy.proxytypewhen parsing the regular proxy string. - Pass
conn->socks_proxy.proxytypewhen parsing the SOCKS proxy string, instead of reusing the HTTP proxy type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reported by Codex Security
bagder
force-pushed
the
bagder/proxy-type
branch
from
ea02aea to
b83f1fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by Codex Security