Closed
Conversation
It had an 'f' too few Follow-up to cd5ca80 Spotted by Codex Security Test case 3219 added to catch this next time.
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect CURLPROTO_MASK value in lib/protocol.h (missing one hex f) and adds a unit test to prevent regressions, as a follow-up to the earlier change referenced in the PR description.
Changes:
- Correct
CURLPROTO_MASKfrom0x3ffffffto0x3fffffffto include all public protocol bits up toCURLPROTO_GOPHERS(bit 29). - Add unit test
unit3219plus the corresponding test spectest3219. - Wire the new test into the unit and data test makefiles.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/protocol.h |
Fixes the protocol bitmask to include all intended public protocol bits. |
tests/unit/unit3219.c |
Adds assertions validating mask inclusion/exclusion for key protocol bits. |
tests/unit/Makefile.inc |
Registers the new unit test source in the unit test bundle. |
tests/data/test3219 |
Adds the test case definition for the new unit test. |
tests/data/Makefile.am |
Includes test3219 in the autotools test case list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
For the record, I think this is overzealous: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It had an 'f' too few
Follow-up to cd5ca80
Spotted by Codex Security
Test case 3219 added to catch this next time.