Repository navigation
Conversation
When composing the <scheme>_proxy environment variable, we assume the handler->scheme name is already lowercase. This makes unit test 1627 verify that is the case. Follow-up to c294f9c Spotted by Codex Security
There was a problem hiding this comment.
Pull request overview
This PR enforces the invariant that libcurl’s registered scheme names (conn->scheme->name) are lowercase, which is relied upon when forming <scheme>_proxy environment variable names.
Changes:
- Update
lib/protocol.cto use lowercase scheme names forsftp,scp,ws, andwss. - Extend unit test
unit1627to assert thatCurl_get_scheme(...)->namematches a lowercased version of the input.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/unit/unit1627.c |
Adds an assertion ensuring returned scheme names are lowercase. |
lib/protocol.c |
Normalizes several scheme name constants to lowercase to match expected invariants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #21033 at 3497c947: Test 1569 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
When composing the <scheme>_proxy environment variable, we assume the handler->scheme name is already lowercase. This makes unit test 1627 verify that is the case. Follow-up to c294f9c Spotted by Codex Security Closes curl#21033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When composing the
<scheme>_proxyenvironment variable, we assume the handler->scheme name is already lowercase.This makes unit test 1627 verify that is the case.
Follow-up to c294f9c
Spotted by Codex Security