transfer: enable custom methods again on next transfer - #21037
Closed
bagder wants to merge 1 commit into
Closed
Conversation
`http_ignorecustom` is set on redirect handling but was not reset between transfers, so once a redirect occurs in the new follow modes, custom request methods were ignored for later transfers on the same handle. Follow-up to fb13923 Detected by Codex Security
There was a problem hiding this comment.
Pull request overview
Fixes a state leak on reused easy handles where data->state.http_ignorecustom could remain set after a redirect in the new follow modes, causing subsequent transfers on the same handle to incorrectly ignore CURLOPT_CUSTOMREQUEST.
Changes:
- Reset
data->state.http_ignorecustomat the start of each transfer inCurl_pretransfer()to ensure custom methods are honored again on the next transfer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Mar 25, 2026
`http_ignorecustom` is set on redirect handling but was not reset between transfers, so once a redirect occurs in the new follow modes, custom request methods were ignored for later transfers on the same handle. Follow-up to fb13923 Detected by Codex Security Closes curl#21037
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
`http_ignorecustom` is set on redirect handling but was not reset between transfers, so once a redirect occurs in the new follow modes, custom request methods were ignored for later transfers on the same handle. Follow-up to fb13923 Detected by Codex Security Closes curl#21037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http_ignorecustomis set on redirect handling but was not reset between transfers, so once a redirect occurs in the new follow modes, custom request methods were ignored for later transfers on the same handle.Follow-up to fb13923
Detected by Codex Security