asyn-thrdd: fix clang-tidy unused value warning#21061
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
asyn-thrdd: fix clang-tidy unused value warning#21061vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
with `-DCURL_DISABLE_SOCKETPAIR=ON`.
```
lib/asyn-thrdd.c:227:5: error: Value stored to 'do_abort' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
227 | do_abort = addr_ctx->do_abort;
| ^ ~~~~~~~~~~~~~~~~~~
```
There was a problem hiding this comment.
Pull request overview
This PR fixes a clang-tidy dead-store warning in the threaded resolver when -DCURL_DISABLE_SOCKETPAIR=ON by adjusting preprocessor scoping so do_abort is only read when the socketpair-based wakeup path is compiled.
Changes:
- Move the
#ifndef CURL_DISABLE_SOCKETPAIRguard to cover the mutex-protecteddo_abortre-check used solely for wakeup signaling. - Prevent
do_abortfrom being assigned in configurations where the value is never subsequently used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with
-DCURL_DISABLE_SOCKETPAIR=ON.