tool_operate: fix memory-leak on failed uploads#21062
Closed
Conversation
Add test case 1673 to do repeated upload failures and verify there is no leak. Reported-by: James Fuller
There was a problem hiding this comment.
Pull request overview
This PR aims to fix a memory leak in the curl tool when uploads fail (especially under retry scenarios), and adds a regression test intended to catch the leak.
Changes:
- Centralize
per_transferresource cleanup indel_per_transfer()(includingper->curl,per->url,per->outfile,per->uploadfile). - Remove now-redundant per-transfer cleanup from
post_per_transfer(). - Add test case 1673 and register it in the test data Makefile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/tool_operate.c |
Moves easy-handle and per-transfer string frees into del_per_transfer() to avoid leaks when transfers are deleted without full post-cleanup. |
tests/data/test1673 |
Adds a new test intended to exercise repeated upload failures with --retry. |
tests/data/Makefile.am |
Registers test1673 in the testcases list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test case 1673 to do repeated upload failures and verify there is no leak.
Reported-by: James Fuller